This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Conversation
This pull-request updates the processing of the feeds to avoid pruning our history of recently-seen-state if we received any errors fetching our feeds. This is suboptimal, because the local state will continue to grow if there are broken feeds in our configuration file. However this is better than constantly renotifying on previously-seen items when/if transient errors occur. To solve this properly would require a per-feed directory to maintain state of entries beneath. We will evolve in that direction but it will require a migration plan first. This closes #80.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request updates the processing of the feeds to avoid
pruning our history of recently-seen-state if we received any
errors fetching our feeds.
This is suboptimal, because the local state will continue to grow
if there are broken feeds in our configuration file. However this
is better than constantly renotifying on previously-seen items
when/if transient errors occur.
To solve this properly would require a per-feed directory to maintain
state of entries beneath. We will evolve in that direction but it
will require a migration plan first.
This closes #80.