This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Conversation
This pull-request, once complete, will close #131 by avoiding the need to process remote feeds which have not changed since their last fetch. We do this by retrieving "Etag" and "Last-Modified" headers when a URL (i.e. feed) is fetched the first time, and use those values in subsequent fetches via headers ("If-Non-Matche", and "If-Modified-Since"). If the remote feed has not changed we should get a 3xx HTTP-status code, and the remote server should be greatful that it has less work to do.
Owner
Author
|
Initial attempt seems reasonable. I get sensible responses - via the hardcoded Sample output I see on curated feeds now: First fetch: Second fetch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request, once complete, will close #131 by avoiding the need to process remote feeds which have not changed since their last fetch.
We do this by retrieving "Etag" and "Last-Modified" headers when a URL (i.e. feed) is fetched the first time, and use those values in subsequent fetches via headers ("If-Non-Matche", and "If-Modified-Since").
If the remote feed has not changed we should get a 3xx HTTP-status code, and the remote server should be greatful that it has less work to do.