Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Resolved all the issues found via go-linter#116

Merged
skx merged 1 commit intomasterfrom
linter/fixes
Nov 2, 2023
Merged

Resolved all the issues found via go-linter#116
skx merged 1 commit intomasterfrom
linter/fixes

Conversation

@skx
Copy link
Copy Markdown
Owner

@skx skx commented Nov 2, 2023

$ go-linter

./cron_cmd.go:112:5: non-zero length test: use `len(s) != 0`
./daemon_cmd.go:97:6: non-zero length test: use `len(s) != 0`
./config_cmd_test.go:16:8: zero value ptr alloc: use &T{} for *T allocation
./export_cmd_test.go:16:8: zero value ptr alloc: use &T{} for *T allocation
./list_cmd_test.go:17:8: zero value ptr alloc: use &T{} for *T allocation
./list_default_template_cmd_test.go:13:8: zero value ptr alloc: use &T{} for *T allocation
./version_cmd_test.go:12:8: zero value ptr alloc: use &T{} for *T allocation
./version_cmd_test.go:40:8: zero value ptr alloc: use &T{} for *T allocation
./template/template_test.go:3:1: unit import: wrap single-package import spec into parenthesis

For reference
go-linter is a shell-script which runs a bunch of stuff, it requires some packages to be installed which is handled by
go-tool-update

$ go-linter

./cron_cmd.go:112:5: non-zero length test: use `len(s) != 0`
./daemon_cmd.go:97:6: non-zero length test: use `len(s) != 0`
./config_cmd_test.go:16:8: zero value ptr alloc: use &T{} for *T allocation
./export_cmd_test.go:16:8: zero value ptr alloc: use &T{} for *T allocation
./list_cmd_test.go:17:8: zero value ptr alloc: use &T{} for *T allocation
./list_default_template_cmd_test.go:13:8: zero value ptr alloc: use &T{} for *T allocation
./version_cmd_test.go:12:8: zero value ptr alloc: use &T{} for *T allocation
./version_cmd_test.go:40:8: zero value ptr alloc: use &T{} for *T allocation
./template/template_test.go:3:1: unit import: wrap single-package import spec into parenthesis

For reference
[go-linter](https://github.com/skx/dotfiles/blob/master/bin/go-linter)
is a shell-script which runs a bunch of stuff, it requires some packages
to be installed which is handled by
[go-tool-update](https://github.com/skx/dotfiles/blob/master/bin/go-tool-update)
@skx skx merged commit 4917a6c into master Nov 2, 2023
@skx skx deleted the linter/fixes branch November 2, 2023 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant