Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Bump go version to 1.17#112

Merged
skx merged 1 commit intoskx:masterfrom
jarkad:bump-go-1.17
Nov 3, 2023
Merged

Bump go version to 1.17#112
skx merged 1 commit intoskx:masterfrom
jarkad:bump-go-1.17

Conversation

@jarkad
Copy link
Copy Markdown
Contributor

@jarkad jarkad commented Oct 24, 2023

I tried compiling this package with go 1.16 and compilation failed. I have little experience with Go, but it looks like one of your dependencies requires go 1.17.

compilation logs 
$ go build .
# golang.org/x/sys/unix
../go/pkg/mod/golang.org/x/sys@v0.11.0/unix/mremap.go:42:10: undefined: unsafe.Slice
../go/pkg/mod/golang.org/x/sys@v0.11.0/unix/syscall.go:83:16: undefined: unsafe.Slice
../go/pkg/mod/golang.org/x/sys@v0.11.0/unix/syscall_linux.go:1018:20: undefined: unsafe.Slice
../go/pkg/mod/golang.org/x/sys@v0.11.0/unix/syscall_linux.go:2300:9: undefined: unsafe.Slice
../go/pkg/mod/golang.org/x/sys@v0.11.0/unix/syscall_unix.go:118:7: undefined: unsafe.Slice
../go/pkg/mod/golang.org/x/sys@v0.11.0/unix/sysvshm_unix.go:33:7: undefined: unsafe.Slice
note: module requires Go 1.17

I tried compiling with go 1.17 and it worked.

@jarkad
bump go version to 1.17
76b2865 
go mod edit -go=1.17 && go mod tidy
@skx skx merged commit 02d0c8d into skx:master Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jarkad @skx