Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Dockerfile improvements#110

Merged
skx merged 4 commits intoskx:masterfrom
visit1985:master
Jan 10, 2024
Merged

Dockerfile improvements#110
skx merged 4 commits intoskx:masterfrom
visit1985:master

Conversation

@visit1985
Copy link
Copy Markdown
Contributor

  • use non-root user to run rss2email
  • install binary to PATH
  • fixed entrypoint

Let me know if this raises any concerns.

Thanks for your work!

@visit1985 visit1985 force-pushed the master branch 2 times, most recently from a8dac82 to c48ff07 Compare June 13, 2023 19:26
@faan11
Copy link
Copy Markdown
Contributor

faan11 commented Jan 10, 2024

any news about these changes? LGTM @skx

@skx
Copy link
Copy Markdown
Owner

skx commented Jan 10, 2024

Somehow I'd managed to gloss over this.

I'll test it out tonight, but at an initial look it seems reasonable - thanks for the reminder.

@skx skx self-assigned this Jan 10, 2024
@skx skx merged commit 2547726 into skx:master Jan 10, 2024
@StayPirate
Copy link
Copy Markdown
Contributor

Tested on my side as well. It works great, but it required me to manually jump into the associated docker named-volume and change the owner of all persistent files: chmod -R app:app .rss2email.

@skx
Copy link
Copy Markdown
Owner

skx commented Jan 10, 2024

Same for me, sadly. Took a moment to work out why I was seeing permission denied, but I guess I make a new release tomorrow and document this explicitly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants