[ENH] remove dangling _fmt usage in detection base and validation#9577
Open
ojuschugh1 wants to merge 1 commit intosktime:mainfrom
Open
[ENH] remove dangling _fmt usage in detection base and validation#9577ojuschugh1 wants to merge 1 commit intosktime:mainfrom
ojuschugh1 wants to merge 1 commit intosktime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #7388. See also #6265, #6958.
What does this implement/fix? Explain your changes.
Removes two leftover pieces of dead code that were missed after the
_fmtdeprecation in #6265:check_fmtinsktime/utils/validation/detection.pyhad no callers anywhere in the codebase, so it's been removed along with its entry in__all__._transform_scoresinsktime/detection/base/_base.pywas accidentally defined twice in a row. The duplicate has been removed.Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
Just confirming that
check_fmtis truly unused and safe to drop, and that removing the duplicate_transform_scoresdoesn't affect any subclass behavior.Did you add any tests for the change?
No - both changes are pure deletions of dead code, so no new tests are needed. Existing tests cover the affected paths.
Any other comments?
Pretty straightforward cleanup. Happy to add a deprecation notice for
check_fmtfirst if that's preferred over a hard removal.For all contributions
How to: add yourself to the all-contributors file in the
sktimeroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
maintainerstag - do this if you want to become the owner or maintainer of an estimator you added.See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.