Skip to content

Upgrade nbqa#794

Merged
mloning merged 1 commit intosktime:mainfrom
MarcoGorelli:upgrade-nbqa
Apr 10, 2021
Merged

Upgrade nbqa#794
mloning merged 1 commit intosktime:mainfrom
MarcoGorelli:upgrade-nbqa

Conversation

@MarcoGorelli
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Hey @mloning - hope you're well!

Am just upgrading the nbqa version here, are there's been a number of fixes/improvements recently

As an aside, I'd suggest using pre-commit-ci, which autoupdates all hooks each week!

@MarcoGorelli MarcoGorelli requested a review from mloning as a code owner April 9, 2021 17:19
@mloning
Copy link
Copy Markdown
Contributor

mloning commented Apr 9, 2021

Thanks @MarcoGorelli - pre-commit-ci looks interesting!

@mloning
Copy link
Copy Markdown
Contributor

mloning commented Apr 10, 2021

Thanks again @MarcoGorelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants