master to main conversion in docs folder closes #644#667
master to main conversion in docs folder closes #644#667mloning merged 9 commits intosktime:mainfrom ayan-biswas0412:ayan/master-2-main
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloning
left a comment
There was a problem hiding this comment.
Thanks @ayan-biswas0412 - this looks all good to me. Could you also check the .rst and .md files in the root directory of the repo (README etc)?
should I make the changes and push the commits in this PR ?? in that files also |
|
Yes let's do it in this PR too! Once all references in the docs are changed and everything still passes, we can change the CI. |
yah sure I will do that |
|
@ayan-biswas0412 there seems to be some issue with linting, could you take a look please? |
is there any tool to detect this locally ? actually syntax wise this is fine this is a problem of code styling I think |
|
@mloning I have solved the lint errors please review |
|
@mloning all the checks have been passed now and the master to main conversion is ready for now I think |
|
Okay great, thanks @ayan-biswas0412. I'll see if I can rename the branches over the next couple of days! |
|
@ayan-biswas0412 thank you again for working on this! I've now renamed the branch and merged this PR! |
Thank you for merging this 🥰 |
|
I took me a bit longer than expected ... |
Reference Issues/PRs
Fixes #644
What does this implement/fix? Explain your changes.
I have changes occurrences of
masterintomainin the files in the docs but not changed the CIs inside .github folder but in some files like which has external documentation links and which are not part of sktime I have kept them as it isDoes your contribution introduce a new dependency? If yes, which one?
No my contribution is free of any new dependency
What should a reviewer concentrate their feedback on?
Please see if anything more needed to be changed , in some .py files like
setup.pythere was one occurrence of master in the line 5 but it was a documentation link of external documentation so I have not changed that and like this I haven't changed in some other one or two places so please see if there is any more change needed or not.Any other comments?
No
PR checklist
NA
For all contributions
For new estimators