Skip to content

Update CI and maintenance tools#394

Merged
mloning merged 20 commits intomasterfrom
ci
Sep 17, 2020
Merged

Update CI and maintenance tools#394
mloning merged 20 commits intomasterfrom
ci

Conversation

@mloning
Copy link
Copy Markdown
Contributor

@mloning mloning commented Sep 11, 2020 •
edited
Loading

Reference Issues/PRs

#196

What does this implement/fix? Explain your changes.

  • pre-commit config
  • additional code quality checks from check-manifest, flake8-bugbear, flake8-print
  • code formatting using Black
  • updated CONTRIBUTING.md to explain how to use pre-commit
  • minor clean up from new checks: added missing init files, remove redundant feature-importance-graph file (detected by check-manifest)
  • enforces pre-commit checks on the CI servers for changed files only (not all files currently pass), replaces flake8 linting checks on azure dev ops
  • adds Codecov with badge in README for unit test coverage reporting
  • add informational coverage threshold for new PRs

Comments

Leaving existing linting checks on azure dev ops untouched for now.

@mloning
Copy link
Copy Markdown
Contributor Author

mloning commented Sep 11, 2020

Hi @big-o I've finally added black with pre-commit, let me know what you think.

@big-o
Copy link
Copy Markdown
Contributor

big-o commented Sep 11, 2020

Looks great! I don't know too much about flake8, but if black is a strict subset of it then maybe you'd be able to remove the flake8 checks?

@mloning
Copy link
Copy Markdown
Contributor Author

mloning commented Sep 13, 2020

They seem to check slightly different things, so I'll leave them in for now.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 14, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ea9642b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #394   +/-   ##
=========================================
  Coverage          ?   82.49%           
=========================================
  Files             ?      172           
  Lines             ?    11211           
  Branches          ?        0           
=========================================
  Hits              ?     9249           
  Misses            ?     1962           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9642b...4a8b8ed. Read the comment docs.

@mloning
Copy link
Copy Markdown
Contributor Author

mloning commented Sep 15, 2020

Self-reviewed. Looks all good to me. @fkiraly or @big-o let me know if you have time to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mloning @big-o @codecov-commenter