Conversation
fkiraly
left a comment
There was a problem hiding this comment.
Very nice, thanks!!
Didn't think I'd ever see the day where someone figures out what's wrong with our binder!
So it was prophet all along? Go figure.
You forgot to add yourself to .all-contributorsrc, though.
But it's great because it works! |
fkiraly
left a comment
There was a problem hiding this comment.
Hmmmm - it seems that binder works, but it somehow broke CI/CD (see test_examples below and the inability to run jupyter) - could you kindly check what is happening there?
|
Yes I noticed that the Github workflows use the binder requirements file to test the example files. I changed the workflow to include the second requirements file I added. I hope it passes the test now |
|
so, it runs but there's stil the problem of not being able to build a
... any good ideas? All that red output may look scary for the typical user... |
|
Thanks @corvusrabus for the fix - great work! |
Reference Issues/PRs
Fixes #807
Fixes #662
What does this implement/fix? Explain your changes.
The Binder Dockerfile stopped working at some point. I changed the requirements files for the Docker file and it works now. The Docker file "compiles" and I ran the first example notebook in it.
I changed the base Docker image used because the one that is in the current Dockerfile is just an arbitrary one copied from the Binder docs. I think that the Jupyter Notebook Python 3.8 is a reasonable base image because it already contains some of the needed libraries and Python 3.8 is the newest version that can currently be used with Numba (according to my understanding).
This is not an optimal solution yet because something is broken with the way Prophet is being built but this can only be changed once the Prophet developers fix it. I know it is weird to have two requirement files but Prophet doesn't build without having some libraries installed first.
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
For all contributions