Conversation
|
Looks cool now. Could we also add any instructions to install for WSL-2? |
Oh, yes, of course! Sorry for forgetting. Let me take them from your PR, @afzal442. |
|
@afzal442, rephrased it a bit and added it in two places: the |
|
Looking better. Thanks! |
TonyBagnall
left a comment
There was a problem hiding this comment.
I have not actually tried to install following these instructions, but the old ones clearly need updating. Couple of comments:
"thy can be installed" -> this can be installed
I'm not sure about this
"For brevity, we discuss steps 1 and 3 first; step 2 is discussed at the end, as it will depend on the operating system."
surely changing the order does not effect the overall brevity, and describing them out of order just seems strange,
Well, that's how it was, and it's perhaps not brevity but findability. If you have the massive "step 2" section in the middle with branches and sub-sections, you can't easily find the "step 3" section. Would it make sense to have "step 2" as a separate section, perhaps?
Do you have problems with my medieval English? Thine installatione shalt end bifore sundowne |
maybe, I may also be being pedantic
there must be a converter somewhere to refactor it all into olde English, its a good first issue |
Co-authored-by: Markus Löning <markus.loning@gmail.com>
…tute/sktime into install-rework
|
@TonyBagnall, I moved the build requirements into a new section - both the development version install and the advanced set-up reference it. The "step 2" is now in the right place, and references the section. This should address your point. |
|
Points addressed, ready for review. |
mloning
left a comment
There was a problem hiding this comment.
Two minor comments, everything else looks good
This is a rework of the installation guidelines.
They have grown a bit organically and were all over the place.
Was originally going to write the developer guidelines, but I found that these needed a cleaning first.