-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Description
The distance based classifiers are not working properly, and there are several issues related to them. I am going to collate them here and comment on progress fixing them.
-
KNN with msm distance give exact same scores with different hyper-parameters
[BUG] KNN with msm distance give exact same scores with different hyper-parameters #589 -
ColumnEnsembleClassifier fails fitting KNN classifiers
[BUG] ColumnEnsembleClassifier fails fitting KNN classifiers #578 -
Cannot dump proximity forest model using joblib or pickle
[BUG] Cannot dump proximity forest model using joblib or pickle #600 -
AttributeError: 'ProximityStump' object has no attribute 'get_exemplars
[BUG] AttributeError: 'ProximityStump' object has no attribute 'get_exemplars' #598
More issues rolled into this one for clarity
5. Proximity Forest always using 2 processors #663
#663
-
Derivative distance measures out
[BUG] Derivative based distance measures error out #654 -
Distance measure unit testing
Distance measure unit testing #646 -
Variable length distance throws an error
[BUG] Variable length time series throw an error in DTW in elastic.py #645 -
Cross validation bug
[BUG] Cross validation has no effect on KNeighborsTimeSeriesClassifier distance measure parameters #1057 -
Strange PF bug in orchestration
[BUG] unexpected behaviour in Proximity Forest (unspecified) #1114
There are several related issues which I am investigating, this is a work in progress.
- the sktime knn classifier has changed, and no longer has a _fit(X) method, so we use fir(X,y)
- the DTW window sizes are, we think, not set correctly
- there may be an issue with data transposition
actions are:
- get the classifiers working
- black box correctness vs tsml toolkit
- write unit tests for distance functions and classifiers
- make sure all tuning works correctly
- fix the above issues
fixed
KNeighboursTimeSeriesClassifier throws errors with multivariate time series data when algorithm is set to either 'kd_tree' or 'ball_tree
#328
Euclidean distance for KNN
#551
Bug with KNN
#413
TypeError from KNeighborsTimeSeriesClassifier
#608