Skip to content

[ENH] Student's t-distribution#49

Merged
fkiraly merged 4 commits into
sktime:mainfrom
alex-gregory-ds:add-t-distribution
Aug 27, 2023
Merged

[ENH] Student's t-distribution#49
fkiraly merged 4 commits into
sktime:mainfrom
alex-gregory-ds:add-t-distribution

Conversation

@alex-gregory-ds

@alex-gregory-ds alex-gregory-ds commented Aug 27, 2023 •
edited by fkiraly
Loading

Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Mirror of sktime sktime/sktime#5050. Towards #22

What does this implement/fix? Explain your changes.

Add student's t-distribution.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've reviewed the project documentation on contributing
  • I've added myself to the list of contributors.
  • The PR title starts with either [ENH], [CI/CD], [MNT], [DOC], or [BUG] indicating whether
    the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions
  • Unit tests have been added covering code functionality
  • Appropriate docstrings have been added (see documentation standards)
  • New public functionality has been added to the API Reference

@fkiraly fkiraly changed the title [ENH]Add student's t-distribution [ENH] Student's t-distribution Aug 27, 2023
@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators implementing algorithms Implementing algorithms, estimators, objects native to skpro labels Aug 27, 2023
fkiraly
fkiraly approved these changes Aug 27, 2023
View reviewed changes

@fkiraly fkiraly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I fixed some minor things:

  • docstring example import
  • first line, currently older precommit version than sktime

@codecov-commenter

codecov-commenter commented Aug 27, 2023 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.03%. Comparing base (7fa2aa6) to head (6bb62c4).
⚠️ Report is 526 commits behind head on main.

Files with missing lines Patch % Lines
skpro/distributions/t.py 98.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   70.56%   71.03%   +0.47%     
==========================================
  Files         102      103       +1     
  Lines        4709     4789      +80     
  Branches      847      853       +6     
==========================================
+ Hits         3323     3402      +79     
  Misses       1166     1166              
- Partials      220      221       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly fkiraly merged commit 3947650 into sktime:main Aug 27, 2023
@fkiraly fkiraly mentioned this pull request Aug 27, 2023
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fkiraly fkiraly fkiraly approved these changes

Assignees

No one assigned

Labels

enhancement implementing algorithms Implementing algorithms, estimators, objects native to skpro module:probability&simulation probability distributions and simulators

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alex-gregory-ds @codecov-commenter @fkiraly