[ENH] Alpha distribution#356
Merged
Merged
Conversation
VascoSch92
reviewed
May 23, 2024
fkiraly
approved these changes
May 23, 2024
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Looks good!
Not blocking, but we should:
- add an explanation of the parameterization to the docstring - the "alpha" distribution is not a common one, so more explanation on how to obtain it would also be useful (e.g., in relation to Gaussian)
- fix the type annotations, as @VascoSch92 suggests
fkiraly
reviewed
May 23, 2024
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Implements Alpha Distribution. Towards https://github.com//issues/22Does your contribution introduce a new dependency? If yes, which one?
NoDid you add any tests for the change?
NoPR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.