[ENH] Gamma Distribution#355
Conversation
| where `\tau(\alpha)` is the Gamma function. | ||
| For all positive integers,`\tau(\alpha) = (alpha-1)!`. |
There was a problem hiding this comment.
| where `\tau(\alpha)` is the Gamma function. | |
| For all positive integers,`\tau(\alpha) = (alpha-1)!`. | |
| where :math:`\tau(\alpha)` is the Gamma function. | |
| For all positive integers, :math:`\tau(\alpha) = (\alpha-1)!`. |
There was a problem hiding this comment.
Could you please be so kind to write the expression for the f(x) as well in this LaTex format I am not able to do it with trial and error, or maybe lead me to some resource that explains the usage.
There was a problem hiding this comment.
but f looks correct already - does it not compile to sth readable?
You can always test it by putting it in markdown, like this:
There was a problem hiding this comment.
for some reason the expression is working when i use $$ in markdown here but it doesnt convert in readthedocs and instead if i use ..math:: neither here nor there it is readable.
There was a problem hiding this comment.
I'm looking at the docs, it is perfectly readable for me:
fkiraly
left a comment
There was a problem hiding this comment.
Looks good to me.
Typos in docstring should be fixed, though are not blocking.
|
Finally it works! please let me know if anything else needs to be done. |
|
oh, I see - you fixed it. Great! |
What does this implement/fix? Explain your changes.
Implements Gamma distribution.
Does your contribution introduce a new dependency? If yes, which one?
No
Did you add any tests for the change?
Yes
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.