[ENH] Beta Distribution#298
Conversation
|
|
||
| class Beta(_ScipyAdapter): | ||
| r"""Beta distribution. | ||
|
|
There was a problem hiding this comment.
could you add a short note about parameterization? Have a look at the other distributions.
The reason is, many distributions have different parameterizations, e.g., normal can be parameterized by sigma or sigma-squared. It suffices to spell out one of the distribution defining functions, usually I choose the "simplest" for users to understand.
Let me know if you are unsure, then I will add it later.
There was a problem hiding this comment.
Recently, I have added the parameterization note about the beta distribution. I had a look at the other distributions, and a lot of them are noted by PDF or CDF formula. That's why I tried to add the PDF formula as I think it is easier to understand, in the context of Beta Distribution. I took the formula from the Wikipedia. I added the PDF formula as given
Please let me know if there is something I missed! Also, I am totally fine as well if you want to modify the PR as well
There was a problem hiding this comment.
yes, that works, especially with the explanation that B is for normalization.
fkiraly
left a comment
There was a problem hiding this comment.
Excellent - it looks like we have minimized the effort to add more distributions with the adapter!
I suppose this takes 5 or 10 min per distribution now?
I left a few comments.
Well, you tell me - you implemented it, was it easier? |
Sure! It was much easier compared to when I tried to implement the Weibull / LogLogistic distributions 😅 |
Reference Issues/PRs
Towards #22
What does this implement/fix? Explain your changes.
This PR implements Beta distribution based on Scipy Adapter
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.