[ENH] Log-normal probability distribution#218
Conversation
|
do you need feedback on this? FYI, you do not need to close PR to update them, if you update the branch on your fork, the PR will automatically update. |
the energy functional hasn't been worked out |
fkiraly
left a comment
There was a problem hiding this comment.
Thanks!
Looks ok. Can you quickly explain how you arrived at the energy term?
Also, please make sure to format your code properly, or the tests will not run:
https://www.sktime.net/en/stable/developer_guide/coding_standards.html
fkiraly
left a comment
There was a problem hiding this comment.
Since you did not comment, I assume you are no longer working on this, so I've wrapped this up now for merge
Reference Issues/PRs
#22
What does this implement/fix? Explain your changes.
Lognormal probability distribution
Does your contribution introduce a new dependency? If yes, which one?
no
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
no
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.