[ENH] Chi-Squared Distribution#217
Merged
Merged
Conversation
fkiraly
requested changes
Mar 23, 2024
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Nice contribution!
Code formatting checks are failing, see here for a guide how to set this up locally:
https://www.sktime.net/en/stable/developer_guide/coding_standards.html
For the energy, let me know if you need help. Does the reference from the issue not have an explicit formula?
Contributor
Author
|
I do not understand what the build issue is, as it doesn't seem to show the files I modified, rather some other files |
Collaborator
|
note sure, I've restarted the tests - let's see. |
Collaborator
|
failures seem genuine - methods return unexpected values. Have you run |
fkiraly
approved these changes
Apr 25, 2024
fkiraly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. Updated with new extension contract.
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #22 for chi-squared case
What does this implement/fix? Explain your changes.
Implements some methods for chi-squared distribution
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Current state of code, and what all capabilities need to be modified / made better (particularly, I am trying to implement energy and make ppf more native than a scipy wrapper)
Did you add any tests for the change?
Nope
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
Thanks for contributing!
-->