MNT drop python=3.7 support #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [tool.black] | ||
| line-length = 88 | ||
| target_version = ['py37', 'py38', 'py39', 'py310'] | ||
| target_version = ['py38', 'py39', 'py310', 'py311'] |
Collaborator
There was a problem hiding this comment.
Suggested change
| target_version = ['py38', 'py39', 'py310', 'py311'] | |
| target_version = ['py38', 'py39', 'py310'] |
Not sure if it hurts to have it there. If not, just ignore.
Member
Author
There was a problem hiding this comment.
we do code in py311, so I think this is better to stay.
Collaborator
There was a problem hiding this comment.
It's unclear to me what this option really does. Is it only relevant when a new Python version changes syntax? Anyway, I'm fine with keeping it.
Member
Author
There was a problem hiding this comment.
As in, the output should be valid in all these python versions, I think.
Collaborator
BenjaminBossan
left a comment
There was a problem hiding this comment.
Can we not get rid of fixes.py completely now?
Member
Author
|
CI is green @BenjaminBossan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #246, fixes #245 , but doesn't add 3.11. #246 will add that.