Quote paths in shell commands to support directories with spaces#102
Merged
marcprux merged 2 commits intoskiptools:mainfrom Feb 4, 2026
Merged
Quote paths in shell commands to support directories with spaces#102marcprux merged 2 commits intoskiptools:mainfrom
marcprux merged 2 commits intoskiptools:mainfrom
Conversation
The buildAndroidSwiftPackageDebug and buildLocalSwiftPackage Gradle
tasks pass paths to sh -c without shell quoting. When any path in the
chain contains spaces (e.g. "Test Dir/app-project/..."), shell word
splitting breaks the command arguments, causing errors like:
error: 4 unexpected arguments:
'Dir/app-project/.build/Android/AppName/jni-libs' ...
Add double quotes around all path-containing interpolations in the
shell command strings: skipcmd, swiftBuildFolder(), swiftSourceFolder(),
and the module-cache-path argument.
Fixes skiptools/skip#604
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @wjdtjq6 on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
Member
|
This looks good, thanks for the contribution. I'll merge it and cut a new release in the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buildAndroidSwiftPackageDebug and buildLocalSwiftPackage Gradle tasks pass paths to sh -c without shell quoting. When any path in the chain contains spaces (e.g. "Test Dir/app-project/..."), shell word splitting breaks the command arguments, causing errors like:
error: 4 unexpected arguments:
'Dir/app-project/.build/Android/AppName/jni-libs' ...
Add double quotes around all path-containing interpolations in the shell command strings: skipcmd, swiftBuildFolder(), swiftSourceFolder(), and the module-cache-path argument.
Fixes skiptools/skip#604
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift test