Fix playback rate to match iOS Float type#16
Merged
marcprux merged 2 commits intoskiptools:mainfrom Jan 12, 2026
Merged
Conversation
- Change rate property from Double to Float with explicit cast to match iOS API - Fix rate setter to preserve playback state when adjusting speed, since Android's setPlaybackParams automatically starts playback by default
ios has optional delegate, need this to match
Member
|
This looks good! Should I wait on merging this for the delegate implementation (in which case this PR should be converted to a draft), or are you thinking of adding that later? |
Contributor
Author
|
I didnt manage to get the delegate working, so not planning to update it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Pull Request Checklist:
swift test