Fix asset:// URL loading for MediaPlayer#10
Merged
marcprux merged 3 commits intoskiptools:mainfrom Aug 4, 2025
Merged
Conversation
marcprux
requested changes
Aug 4, 2025
Member
marcprux
left a comment
There was a problem hiding this comment.
This looks good, but I was under the impression that MediaPlayer/ExoPlayer has automatic support for "asset://" URLs, and there are a number of examples on GitHub that use this scheme, like https://github.com/joelsmith/audiobookshelf-app/blob/master/android/app/src/main/java/com/audiobookshelf/app/LocalMediaManager.kt#L72.
I guess we never tested it out ourselves, though. I assume you tried and it wasn't working? Was there any error logged in adb logcat, or did the video simply not play?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Fixes an issue with MediaPlayer in the skip-av package when trying to play files from the source directory. The problem was due to an incorrect URL format, which this fix corrects by using the proper asset:/// scheme or file path expected by MediaPlayer.
Labels:
bug, android
Skip Pull Request Checklist:
swift test