ci: update flatpak build environment to use Ubuntu 22.04 for glibc compatibility#549
Merged
ci: update flatpak build environment to use Ubuntu 22.04 for glibc compatibility#549
Conversation
…mpatibility Signed-off-by: Samuel K <skevetter@pm.me>
📝 WalkthroughWalkthroughUpdates the build-flatpak CI job runner from ubuntu-latest to ubuntu-22.04 in two GitHub Actions workflows, with one adding privileged container capabilities and the other adding GLIBC compatibility comments. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/workflows/release.yml (1)
206-214: Clarify and trim the GLIBC rationale comment.The current block is very long and includes text that says Ubuntu 18.04 is more suitable than 22.04, which can confuse future maintainers given this job now uses 22.04. Consider a short, project-specific rationale plus link.
Proposed comment cleanup
- # Use Ubuntu 22.04 to build the flatpak to ensure compatibility with older glibc versions, as recommended by Tauri. For more details, see - # https://v2.tauri.app/distribute/appimage/ - # "Core libraries such as glibc frequently break compatibility with older systems. For this reason, you must build - # your Tauri application using the oldest base system you intend to support. A relatively old system such as - # Ubuntu 18.04 is more suited than Ubuntu 22.04, as the binary compiled on Ubuntu 22.04 will have a higher - # requirement of the glibc version, so when running on an older system, you will face a runtime error like - # /usr/lib/libc.so.6: version 'GLIBC_2.33' not found. We recommend using a Docker container or GitHub Actions to - # build your Tauri application for Linux." + # Use Ubuntu 22.04 for a stable Linux baseline for Flatpak CI and to avoid + # newer-host glibc drift. Context: https://v2.tauri.app/distribute/appimage/ runs-on: ubuntu-22.04🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 206 - 214, Replace the long GLIBC rationale comment above the runs-on: ubuntu-22.04 line with a concise, project-specific note explaining that Ubuntu 22.04 is chosen for build compatibility while linking to Tauri’s documentation for full details; specifically, shorten the existing multi-paragraph explanation to a single line (e.g., "Use Ubuntu 22.04 for Linux builds for compatibility; see https://v2.tauri.app/distribute/appimage/ for GLIBC/build guidance") and keep the runs-on: ubuntu-22.04 setting unchanged..github/workflows/pr-ci.yml (1)
526-534: Keep the GLIBC note concise and consistent with the selected runner.This comment repeats a long quote and includes wording that suggests Ubuntu 18.04 is preferable, which conflicts with the configured 22.04 runner. Please shorten and align the rationale here the same way as in
release.yml.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pr-ci.yml around lines 526 - 534, Shorten and align the GLIBC comment to match the rationale used in release.yml by removing the long quoted passage and the suggestion that Ubuntu 18.04 is preferable; instead state concisely that we use runs-on: ubuntu-22.04 to build the flatpak and ensure a compatible glibc baseline for shipping, keeping the note brief and consistent with other workflow files (edit the comment block above the runs-on: ubuntu-22.04 line).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/pr-ci.yml:
- Around line 526-534: Shorten and align the GLIBC comment to match the
rationale used in release.yml by removing the long quoted passage and the
suggestion that Ubuntu 18.04 is preferable; instead state concisely that we use
runs-on: ubuntu-22.04 to build the flatpak and ensure a compatible glibc
baseline for shipping, keeping the note brief and consistent with other workflow
files (edit the comment block above the runs-on: ubuntu-22.04 line).
In @.github/workflows/release.yml:
- Around line 206-214: Replace the long GLIBC rationale comment above the
runs-on: ubuntu-22.04 line with a concise, project-specific note explaining that
Ubuntu 22.04 is chosen for build compatibility while linking to Tauri’s
documentation for full details; specifically, shorten the existing
multi-paragraph explanation to a single line (e.g., "Use Ubuntu 22.04 for Linux
builds for compatibility; see https://v2.tauri.app/distribute/appimage/ for
GLIBC/build guidance") and keep the runs-on: ubuntu-22.04 setting unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samuel K skevetter@pm.me
Summary by CodeRabbit