Conversation
Signed-off-by: Samuel K <skevetter@pm.me>
There was a problem hiding this comment.
Pull request overview
This PR adds explicit version configuration to the Tauri build action in the release workflow by setting the appVersion parameter. This ensures the desktop application version is derived from the Git tag or ref name rather than relying on the hardcoded "0.0.0" version in package.json.
Changes:
- Added
appVersionparameter to thetauri-actionstep using the same fallback logic as other release parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Samuel K <skevetter@pm.me>
📝 WalkthroughWalkthroughUpdates the GitHub Actions release workflow to install desktop dependencies with a frozen lockfile, derive and normalize a VERSION from the workflow inputs/ref (strip leading Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/release.yml:
- Line 162: The workflow passes the raw tag (inputs.tag || github.ref_name)
directly into yarn version --new-version which can fail if the tag includes a
leading "v"; update the run step so you first assign the tag to a shell variable
(from ${{ inputs.tag || github.ref_name }}), strip any leading "v" (e.g., using
shell parameter expansion VERSION=${VERSION#v}), then call yarn version
--new-version "$VERSION" --no-git-tag-version; ensure you update the single run
line that invokes yarn version --new-version to use the stripped VERSION
variable while keeping the existing yarn install invocation.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build CLI Binary on windows-latest
- GitHub Check: Lint
- GitHub Check: Build CLI Binary on ubuntu-latest
- GitHub Check: Build CLI Binary on macos-latest
Signed-off-by: Samuel K <skevetter@pm.me>
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)
220-239: Strip "v" prefix from version before updating metainfo.xml.The flatpak metadata version field requires semantic versioning without a "v" prefix per AppStream specification. The current code sets
VERSION="${{ inputs.tag || github.ref_name }}"(which includes "v", e.g., "v0.1.0") and applies it directly to the metainfo.xml version attribute, resulting in incorrect metadata. Strip the prefix before the sed replacement:VERSION_CLEAN="${VERSION#v}" sed -i "s/__VERSION__/${VERSION_CLEAN}/g" ./desktop/flatpak/DevPod.metainfo.xml sed -i "s/__DATE__/${DATE}/g" ./desktop/flatpak/DevPod.metainfo.xmlKeep the raw VERSION with "v" prefix for the manifest file (sh.loft.devpod.yml), which correctly references GitHub release download URLs that expect the "v" prefix in the tag.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
162-166: LGTM! Version normalization logic is correct.The bash pattern substitution
${VERSION#v}correctly strips the leading "v" prefix, andyarn versionproperly updates the package.json for the Tauri build without creating git tags.Consider adding debug output to aid troubleshooting:
📝 Optional: Add debug output
run: | yarn install --frozen-lockfile VERSION=${{ inputs.tag || github.ref_name }} VERSION="${VERSION#v}" + echo "Setting app version to: $VERSION" yarn version --new-version "$VERSION" --no-git-tag-version
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build CLI Binary on windows-latest
- GitHub Check: Build CLI Binary on macos-latest
- GitHub Check: Build CLI Binary on ubuntu-latest
- GitHub Check: Lint
Signed-off-by: Samuel K skevetter@pm.me
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.