feat(cli/environment): use environment variables to set all flags not supplied explicitly#257
Merged
dubinsky merged 1 commit intoskevetter:mainfrom Jan 9, 2026
Conversation
969caad to
1c2e870
Compare
… supplied explicitly Tighter integration with the `spf13/pflag` and `spf13/cobra` libraries allows for a better approach to setting default values of the CLI flags from the environment variables: - this defaulting is done in one place (`root.go`); - all the code enabling defaulting of specific flags is reverted; - all the flags of all the commands can now be defaulted using environment variables; - names of the environment variables are calculated from the names of the flags in a consistent way; - there is no need to duplicate `pflag` code for the parsing of the non-string flags. Signed-off-by: Leonid Dubinsky <dub@podval.org>
1c2e870 to
a092b8f
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the CLI's environment variable handling for flags by centralizing the logic in a single location. Instead of manually specifying environment variables for each flag using custom wrapper functions, the new approach automatically generates environment variable names from flag names and applies them uniformly across all commands.
Key Changes
- Centralized environment variable handling in
cmd/root.gowith newinheritCommandFlagsFromEnvironmentandinheritFlagsFromEnvironmentfunctions - Removed custom flag wrapper functions (
StringVarE,BoolVarE,StringArrayVarE,StringSliceVarE) fromcmd/flags/flags.go - Renamed functions from
Propagate*toInherit*for better semantic clarity - Updated all flag definitions across commands to use standard
cobra/pflagmethods
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/root.go | Added centralized environment variable inheritance logic that automatically maps all flags to environment variables with consistent naming |
| cmd/flags/flags.go | Removed custom flag wrapper functions and environment variable helper functions; simplified to use standard pflag methods |
| cmd/up.go | Converted flag definitions from custom *VarE functions to standard pflag methods; renamed propagatedEnvironmentVariables to inheritedEnvironmentVariables |
| cmd/provider/use.go | Converted flag definitions to standard methods; hardcoded environment variable prefix from constant to literal string |
| cmd/provider/set_options.go | Converted flag definition to standard method |
| cmd/provider/add.go | Converted flag definition to standard method |
| cmd/ide/use.go | Updated function call and hardcoded environment variable prefix |
| pkg/options/options.go | Renamed PropagateFromEnvironment and PropagateOptionsFromEnvironment to InheritFromEnvironment and InheritOptionsFromEnvironment |
| pkg/options/options_test.go | Updated test function name to match the renamed function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skevetter
approved these changes
Jan 9, 2026
Comment on lines
+164
to
+165
| // do not prepend "DEVPOD_" to the environment variable name if the flag name starts with "devpod" | ||
| // (applies to one flag - "devpod-home"). |
Owner
There was a problem hiding this comment.
should we made a TODO to update devpod-home to be consistent with the other variables?
Author
There was a problem hiding this comment.
Change it to home? I think it is ok as is - home is too generic...
Author
There was a problem hiding this comment.
Besides, breaking people who use devpod-home flag is not worth it I think...
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tighter integration with the
spf13/pflagandspf13/cobralibraries allows for a better approach to setting default values of the CLI flags from the environment variables:root.go);pflagcode for the parsing of the non-string flags.