feat(ide/jetbrains): suppress JetBrains trust dialog#251
feat(ide/jetbrains): suppress JetBrains trust dialog#251dubinsky merged 1 commit intoskevetter:mainfrom
Conversation
skevetter
left a comment
There was a problem hiding this comment.
supplying --workspace-env REMOTE_DEV_TRUST_PROJECTS=1 to devpod up explicitly is arguably even more annoying...
I am not sure I follow. Could there be a case where the user is working on a repository and wants to grant trust through env or through the trust dialog?
For security purposes, I think the default should be to deny unless an override is supplied.
The dialog provides three choices (see https://www.jetbrains.com/help/idea/project-security.html#projects_security):
|
|
I am fine with this change, but let's log a warning message stating that it is opening in unsafe (or trusted) mode. If there is a demographic of 1 user, I don't see any reason for us to not support that preference, and we could reevaluate at a later time. |
6d0b36e to
dceaf3c
Compare
In the current form, this pull request no longer auto-sets anything; instead, it provides a way to supply the What do you think - should I re-instate the trust dialog suppression (with a warning you suggested) or leave it at that? Thanks! |
skevetter
left a comment
There was a problem hiding this comment.
the trust dialog suppression (with a warning you suggested)
If you are using IntelliJ on the regular basis, then I would add it. It improves the UX.
When a workspace is opened for the first time in a JetBrains IDE, a trust dialog pops up. In most cases, is useless and annoying. Fortunately, JetBrains provide a way to suppress this dialog: set a workspace environment variable `REMOTE_DEV_TRUST_PROJECTS` to any value. Unfortunately, supplying `--workspace-env REMOTE_DEV_TRUST_PROJECTS=1` to `devpod up` explicitly on the `devpod up` command line is arguably even more annoying... This pull request adds a few more environment variables that can be used to supply values for devpod CLI options. One of them can be used to seamlessly suppresses JetBrains trust dialog: set `DEVPOD_WORKSPACE_ENV="REMOTE_DEV_TRUST_PROJECTS=1"` - for instance, in `.envrc` file. Signed-off-by: Leonid Dubinsky <dub@podval.org>
dceaf3c to
8030213
Compare
I do, but my UX will be fine with this pull request as is: it lets me set I think for now I will just add the general facility to use environment variables |
|
@skevetter for some reason, my pull request branches do not get deleted on merge... |
When a workspace is opened for the first time in a JetBrains IDE, a trust dialog pops up.
In most cases, is useless and annoying.
Fortunately, JetBrains provide a way to suppress this dialog: set a workspace environment variable
REMOTE_DEV_TRUST_PROJECTSto any value.Unfortunately, supplying
--workspace-env REMOTE_DEV_TRUST_PROJECTS=1to
devpod upexplicitly on thedevpod upcommand line is arguably even more annoying...This pull request adds a few more environment variables that can be used to supply values for devpod CLI options.
One of them can be used to seamlessly suppresses JetBrains trust dialog:
set
DEVPOD_WORKSPACE_ENV="REMOTE_DEV_TRUST_PROJECTS=1"- for instance, in.envrcfile.