feat(cli): handle a few environment variables with correct order of precedence by dubinsky · Pull Request #195 · skevetter/devpod

dubinsky · 2025-12-29T19:07:26Z

first steps in the direction of #196...

dubinsky · 2025-12-29T20:49:38Z

@skevetter none of the checks are triggered by a pull request now, while before most of them were (I think). Is this change intentional? Thanks!

skevetter · 2025-12-29T20:52:56Z

Is this change intentional?

For the (brief) moment, yes. I am refactoring the workflows to better support code contributions and releases.

dubinsky · 2025-12-29T21:20:06Z

Is this change intentional?

For the (brief) moment, yes. I am refactoring the workflows to better support code contributions and releases.

Thank you so much!!

skevetter · 2025-12-31T09:34:27Z

Is this change intentional?

For the (brief) moment, yes. I am refactoring the workflows to better support code contributions and releases.

Thank you so much!!

Thank you for your patience. I think I have the workflows in a better place now.

skevetter · 2025-12-30T03:38:54Z

cmd/flags/flags.go

+// Defines a string flag with specified name, environment variable, default value, and usage string.
+// The argument p points to a string variable in which to store the value of the flag.
+func StringVarE(f *flag.FlagSet, p *string, name string, env string, value string, usage string) {
+	key := "DEVPOD_" + env


minor: I would make DEVPOD_ into a re-usable constant like DevpodEnvPrefix

skevetter · 2025-12-30T03:42:44Z

cmd/flags/flags.go

+		if err == nil {
+			return result
+		}
+		return def


question: Should the error fail silently or should we log it here? And check if error is not nil first

if err != nil { log.Warnf("invalid boolean value %s for key %s, falling back to default %v", value, key, default) return default }

skevetter · 2025-12-30T03:43:15Z

cmd/flags/flags.go

+	f.BoolVar(p, name, GetBoolEnv(key, value), usage+". You can also use "+key+" to set this")
+}
+
+func GetBoolEnv(key string, def bool) bool {


opinion: default or defaultValue in lieu of def for clarity

skevetter · 2025-12-30T04:27:25Z

cmd/flags/flags.go


+// Defines a string flag with specified name, environment variable, default value, and usage string.
+// The argument p points to a string variable in which to store the value of the flag.
+func StringVarE(f *flag.FlagSet, p *string, name string, env string, value string, usage string) {


optional: if you can think of a more recognizable value for p *string, it may be helpful to future readers. And same for value, if it is intended to be a default/fallback value then perhaps use defaultValue.

skevetter · 2025-12-30T04:33:44Z

cmd/flags/flags.go

-	flags.StringVar(&globalFlags.Provider, "provider", "", "The provider to use. Needs to be configured for the selected context.")
-	flags.BoolVar(&globalFlags.Debug, "debug", false, "Prints the stack trace if an error occurs")
-	flags.BoolVar(&globalFlags.Silent, "silent", false, "Run in silent mode and prevents any devpod log output except panics & fatals")
+	StringVarE(flags, &globalFlags.LogOutput, "log-output", "LOG_OUTPUT", "plain", "The log format to use. Can be either plain, raw or json")


question: wrt comment above, perhaps the prefix would be more visible here as DEVPOD_ENV_PREFIX+VAL (e.g., DEVPOD_ENV_PREFIX+LOG_OUTPUT). Thoughts?

dubinsky · 2025-12-31T17:52:38Z

Thank you for your patience. I think I have the workflows in a better place now.

Thank you!
Various pre-commit checks that used to run last now run first - excellent!

…recedence Signed-off-by: Leonid Dubinsky <dub@podval.org>

Signed-off-by: Leonid Dubinsky <dub@podval.org>

skevetter · 2025-12-31T18:19:13Z

Thank you for your patience. I think I have the workflows in a better place now.

Thank you! Various pre-commit checks that used to run last now run first - excellent!

Great work!

Let me know if you encounter any pain points or have any general feedback. My intent is for contribution process to be streamlined and frictionless for both contributors and reviewers.

Also, if you're interested in being a reviewer, let me know. I would be more than happy to share the work :)

dubinsky · 2025-12-31T18:32:25Z

Great work!

Thank you!

Let me know if you encounter any pain points or have any general feedback.

Thanks!

What is your preferred approach for the branches of the merged pull requests - delete or keep?
I recently started getting errors "executing agent command agent error: /tmp/dub/devpod/agent: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by /tmp/dub/devpod/agent)", and I am not sure what needs to be adjusted - is my Linux distribution too new, are the distributions in the containers and virtual machines that I use too old, or is there a way to build for a specific version of GLibc?
gcloud provider fork needs to be fully adopted and its module names, dependencies and build adjusted; I am not up for that task, so I'll wait for you do wield the magic ;)

My intent is for contribution process to be streamlined and frictionless for both contributors and reviewers.

Great!

Also, if you're interested in being a reviewer, let me know. I would be more than happy to share the work :)

I am honored by this offer, but this being a new code-base in a new programming language for me, I do not yet feel confident enough to accept it. We'll see how it goes ;)

skevetter · 2025-12-31T18:53:54Z

What is your preferred approach for the branches of the merged pull requests - delete or keep?

Delete. To keep things tidy.

I recently started getting errors "executing agent command agent error: /tmp/dub/devpod/agent: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by /tmp/dub/devpod/agent)", and I am not sure what needs to be adjusted - is my Linux distribution too new, are the distributions in the containers and virtual machines that I use too old, or is there a way to build for a specific version of GLibc?

I will have to get back to you on that. There has been a number of dependency upgrades (go, rust, node), upgrading the go version, etc.

the distributions in the containers and virtual machines that I use too old

Possibly this. If you see GLIBC_2.38 not found , in general, it means the program was compiled with a newer version of glibc than what the OS is using.

This may be a build configuration issue I need to investigate. The application is compiled with CGO_ENABLED, so there may be some work involved to unlink that dependency.

gcloud provider fork needs to be fully adopted and its module names, dependencies and build adjusted; I am not up for that task, so I'll wait for you do wield the magic ;)

still on my todo list

I do not yet feel confident enough

no worries

dubinsky · 2025-12-31T21:10:36Z

This may be a build configuration issue I need to investigate. The application is compiled with CGO_ENABLED, so there may be some work involved to unlink that dependency.

I do not think the build picks up ambient version - it is 2.42 on the machine where I build.
Machine where I run using ssh provider has 2.36; it is under my control, so I can up the version there, but things stopped working on standard GCloud machines also...

If this is a result of the changes to the build/dependencies, it would be nice to make it a bit more flexible...

gcloud provider fork needs to be fully adopted and its module names, dependencies and build adjusted; I am not up for that task, so I'll wait for you do wield the magic ;)

still on my todo list

no pressure ;)

dubinsky · 2025-12-31T21:11:16Z

what do I need to do for this to get merged?

skevetter · 2025-12-31T21:31:51Z

what do I need to do for this to get merged?

Nothing on your end. A recent upgrade to tauri v2 messed with some of the artifacts that get built in the release. Once I have that resolved, this change will be merged.

dubinsky · 2025-12-31T21:53:50Z

Thank you!

dubinsky mentioned this pull request Dec 29, 2025

Handle environment variables with correct order of precedence #196

Closed

dubinsky force-pushed the environment-variables-should-override branch from f72ad49 to f42ac8a Compare December 29, 2025 21:19

dubinsky force-pushed the environment-variables-should-override branch 2 times, most recently from c97e278 to 3632fc5 Compare December 30, 2025 03:49

skevetter reviewed Dec 31, 2025

View reviewed changes

dubinsky added 2 commits December 31, 2025 12:53

feat(cli): handle a few environment variables with correct order of p…

f35bec5

…recedence Signed-off-by: Leonid Dubinsky <dub@podval.org>

fixup: review comments

d77b18b

Signed-off-by: Leonid Dubinsky <dub@podval.org>

dubinsky force-pushed the environment-variables-should-override branch from cf13c4f to d77b18b Compare December 31, 2025 17:54

skevetter merged commit 84ad5f8 into skevetter:main Dec 31, 2025
34 checks passed

dubinsky deleted the environment-variables-should-override branch December 31, 2025 21:54

dubinsky mentioned this pull request Jan 2, 2026

GLIBC version #221

Closed

Conversation

dubinsky commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubinsky commented Dec 29, 2025

Uh oh!

skevetter commented Dec 29, 2025

Uh oh!

dubinsky commented Dec 29, 2025

Uh oh!

skevetter commented Dec 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dubinsky commented Dec 31, 2025

Uh oh!

skevetter commented Dec 31, 2025

Uh oh!

dubinsky commented Dec 31, 2025

Uh oh!

skevetter commented Dec 31, 2025

Uh oh!

dubinsky commented Dec 31, 2025

Uh oh!

dubinsky commented Dec 31, 2025

Uh oh!

skevetter commented Dec 31, 2025

Uh oh!

Uh oh!

dubinsky commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dubinsky commented Dec 29, 2025 •

edited

Loading