Closed
Conversation
…ags `--context` and `--provider`. For instance: ```shell $ devpod context create box $ devpod ide use intellij --context default ``` sets the default ide on the 'box' context and not on the 'default' context, as can be verified with ```shell $ devpod ide list $ devpod context use default $ devpod ide list ``` which is wrong ;) The fix seems to be to move a '*' from the structure creation to the structure declaration, the way most of the sub-commands do it. I have only a vague idea of what this all means, this being the first Go code I ever touched, but it does bring up C(++) memories from the last millennium... I applied this adjustment to all the 13 commands that seem to have misplaced that crucial '*': - context create/delete/list/set-options/use - ide list/options/set-options/use - provider list/list-available/set-options/use It is not clear to me how this was not detected earlier ;) Please review! Signed-off-by: Leonid Dubinsky <dub@podval.org>
Signed-off-by: Samuel K <69881238+skevetter@users.noreply.github.com>
Signed-off-by: Samuel K <69881238+skevetter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--contextand--provider.