Merged
Conversation
tarekio
suggested changes
Jan 24, 2025
Contributor
tarekio
left a comment
There was a problem hiding this comment.
This PR creates a mismatch between the api responses in create and update.
…353-duplicated-rows-when-creating-records
Contributor
Author
|
@tarekio I’ve reverted the backend changes and removed the code that was manually adding the new item to the table. Since the table data is already being refreshed after creating a new record, this should resolve the issue with duplicate entries. |
…YNT-1353-duplicated-rows-when-creating-records
…am (defaults to 1) for returning the created object in desired json format
…YNT-1353-duplicated-rows-when-creating-records
level09
reviewed
Jun 17, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
All good, only the opanapi doesn't validate correctly. and need a small path fix.
- This fix ensures that the OpenAPI specification validates correctly and properly references the schema definitions for the 417 error responses in the create endpoints.
tarekio
approved these changes
Jun 18, 2025
Contributor
tarekio
left a comment
There was a problem hiding this comment.
Perfect. We can address other endpoints in a future PR if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
Problem:
Currently, when creating records on pages such as bulletins, actors, etc., the newly created item is pushed directly into the table without an ID. This causes occasional visual artifacts where the table displays duplicate rows.
Solution:
This PR resolves the issue by using the server response, which includes the correct ID, to update the table. This ensures the integrity of the data displayed and eliminates duplicate rows caused by the missing ID.
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]