Fix pagination after bulk updates on the bulletins page#72
Merged
Conversation
level09
approved these changes
Jan 22, 2025
tarekio
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
This PR addresses an issue where the bulletins page refetches data with incorrect pagination after a bulk update, causing the table to display more items than initially selected (e.g., more than 10 records when set to show 10).
Steps to Reproduce:
Navigate to the bulletins page.
Ensure the database contains at least 11 records.
Set the table to display only 10 records per page.
Select multiple checkboxes and perform a bulk update.
After the bulk update is completed, observe that the page sends a request with page=undefined&per_page=undefined, resulting in the endpoint defaulting to per_page=30 and displaying more records than expected.
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]