Merged
Conversation
…352-Autoscroll-to-invalid-field
tarekio
approved these changes
Jan 24, 2025
level09
reviewed
Jun 2, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
Perfect and works well @apodacaduron
Just very minor UX improvement: we can perhaps focus the invalid element automatically ?
pseudo code
if (element.focus) {
setTimeout(() => element.focus(), 300) // Wait for scroll to complete
}
Contributor
Author
|
@level09 updated! |
level09
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
On pages like Actors, Bulletins, Locations and Incidents, when adding or editing a new record, if there’s an invalid element auto scroll to the invalid element, this will make it easier for users to find the problem on the form
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]