Merged
Conversation
tarekio
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
This PR phases out '200' and '302' responses expected by the test client for anonymous client, instead sets request headers to receive the correct 401 repsonse.
follow_redirects=Truebecause almost all endpoints respond to test client with an initial 308.If the test client sends header
Accept: */*the redirects will result in sending html content of the login page in anonymous client tests. However, if we explicitly set that header toAccept: application/jsonthen a proper 401 API response is received after the redirect.Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]