Conversation
level09
left a comment
There was a problem hiding this comment.
This looks great. but can we fix this scenario in config state :
- go to system settings ,
save settingsbutton is disabled - go to maps tab, ->
save settingsbutton gets activated.
I think our geomap component needs a fix as it emits or changes the state of our config.
…github.com/sjacorg/bayanat into BYNT-1333-Implement-Sys-Setting-new-design
|
@level09 Thank you i've updated GeoMap to not emit if the initial coordinates are the exact same as the ones currently set in the map |
…334-Implement-Component-Data-new-design
…333-Implement-Sys-Setting-new-design
…://github.com/sjacorg/bayanat into BYNT-1333-Implement-Sys-Setting-new-design
…333-Implement-Sys-Setting-new-design
level09
left a comment
There was a problem hiding this comment.
System Administration
Small issue I Found, If i go to System Administration Dashboard, Maps tab and change only coordinates, the diff shows Diameter change to 1000 , maybe we need to fix default value bindings ? let me know if this is better done on the backend API.
Tab URLs and Router
It is nice to have the URL respond to the current active tab, but the history is not really functional, can we make it work ? like we do with drawers history ? (perhaps replace replace with push)
tarekio
left a comment
There was a problem hiding this comment.
Good overall, Import tools tab needs some work to match design.
…333-Implement-Sys-Setting-new-design
|
@tarekio updated, import tools should better match figma now |
Jira Issue
Description
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]