Conversation
Co-authored-by: cango91 <can.gologlu@gmail.com> Co-authored-by: Daniel Apodaca <apodacaduron@gmail.com>
Contributor
@tarekio FYI this feedback was addressed in the other repo, so should be good now |
tarekio
reviewed
Jan 16, 2025
Adds notification settings with app-managed read-only fields mixed with configurable fields. Adds tests for added functionality.
…gs with enum values in notification_settings, config_utils and tests
level09
requested changes
Aug 7, 2025
level09
requested changes
Aug 8, 2025
enferno/migrations/20250718_153735_create_notification_table.sql
Outdated
Show resolved
Hide resolved
enferno/migrations/20250718_153735_create_notification_table.sql
Outdated
Show resolved
Hide resolved
enferno/migrations/20250718_153735_create_notification_table.sql
Outdated
Show resolved
Hide resolved
level09
approved these changes
Aug 11, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
This is good, Everything is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Phase 1
Phase 2
Phase 3
Phase 4
Phase 5
Phase 6
Phase 7
Phase 8 (PENDING)
BYNT-1249
BYNT-1254
BYNT-1347
BYNT-1349
Description
[Brief description of changes]
Checklist
Additional Notes
GET /admin/api/notificationsreturn a paginated list of all notifications for the current user (descending by created date). Acceptspageandper_pagequery parameters. A sample response looks like belowGET admin/api/notifications/unread/count: return the number of unread notifications for the current user. Will have only one field in JSON response unread_countPOST admin/api/notifications/<int:id>/read: mark the notification with id as read, if it belongs to the current user. Will return a message and the notification on success.Notification Settings
GET /admin/api/configuration/configuration response will now contain a dict keyed "NOTIFICATIONS" that is a mix of read-only and configurable items and fields.in_app_lockedandemail_lockedare read-only fields. Any modifications to these fields will be ignored, as well as any modifications to fields that are marked "locked". That is to say, you can omit the "LOGIN_NEW_IP" whenPUTing the configuration, because all of its fields are read-only, it will be ignored by the backend completely and won't be actually persisted in the configuration file.Some notifications will have a mix of locked and unlocked fields. Modifications made to the unlocked fields will be persisted, whereas any modifications to locked fields will be ignored. Any changes toin_app_lockedoremail_lockedare also ignored.Any notification configuration sent from the frontend is persisted as is (in
config.json), but security-related ones get overridden at runtime when loading the settings.