Conversation
…327-Satellite-imagery-is-broken-in-GeoMap-and-GlobalMap
tarekio
suggested changes
Jan 14, 2025
Contributor
tarekio
left a comment
There was a problem hiding this comment.
This is good so far but we need to add proper attribution for the satellite imagery: https://about.google/brand-resource-center/products-and-services/geo-guidelines/#required-attribution
…Map-and-GlobalMap
level09
reviewed
Jan 16, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
Hi @apodacaduron just a small request. can we convert the coding style to use options api ?
…327-Satellite-imagery-is-broken-in-GeoMap-and-GlobalMap
…balMap' of https://github.com/sjacorg/bayanat into BYNT-1327-Satellite-imagery-is-broken-in-GeoMap-and-GlobalMap
Contributor
Author
|
@level09 updated back to options api should be working now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
Satellite imagery is supposed to be enabled if a google maps api is added to the setting. A button will appear which allows the user to switch between OSM and Google. However that button doesn’t appear now. Google Maps js seems to be loaded correctly so the issue could be in the two components themselves, possible introduced during v3 migration.
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]