Skip to content

Video playback issues#45

Merged
tarekio merged 14 commits intomainfrom
BYNT-1204-video-playback-issues
Jan 17, 2025
Merged

Video playback issues#45
tarekio merged 14 commits intomainfrom
BYNT-1204-video-playback-issues

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Jan 2, 2025

Jira Issue

  1. 1318
  2. 1204

Description

Improvements to media player

Testing Instructions:

  1. Upload multiple videos to at least two bulletins or actors, and ensure they are saved (videos must be hosted on S3).
  2. Navigate to the main bulletins table and click on a row that contains videos.
  3. The sidebar will open. Play all the videos in that bulletin. If all videos play correctly, close the sidebar and move on to another bulletin.
  4. Repeat the previous step until you find a video that does not play correctly.
  5. Alternatively, you can click the pencil icon to edit a bulletin and play the videos directly from the dialog box.

For additional reference, you can check the videos associated with this ticket: BYNT-1318.

The whole idea is to fix this error when we actually have a valid video source:
image

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio January 2, 2025 18:28
@apodacaduron apodacaduron self-assigned this Jan 2, 2025
Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working against reproduction steps. Tested with other formats and on local filesystem, both seems to be working well. @level09 please review and approve.

@tarekio tarekio requested a review from level09 January 15, 2025 15:16
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apodacaduron this is good. but would it be possible to centralize the redundant code we have in both BulletinCard and ActorCard in media-mixin ?

I feel we have an opportunity here not to repeat the same code and move all media related code into the mixin.

Let me know if there are any challenges.

@apodacaduron
Copy link
Contributor Author

@level09 updated

Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 🚀

@tarekio tarekio merged commit 2641ac9 into main Jan 17, 2025
@tarekio tarekio deleted the BYNT-1204-video-playback-issues branch January 17, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants