bugfix: remove no longer needed options watcher#43
Merged
tarekio merged 4 commits intosjacorg:mainfrom Jan 14, 2025
Merged
Conversation
Since `update:options` on table already emits (https://vuetifyjs.com/en/api/v-data-table-server/#events-update:options) when options changes we don't need separate watcher for it. That way it will do just one request instead of two.
Member
|
Thanks for your contribution. We're reviewing this and will get back to you ASAP. |
level09
approved these changes
Jan 13, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
Sounds good. we no longer watch the options after migrating to v3
tarekio
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
update:optionson table already emits (https://vuetifyjs.com/en/api/v-data-table-server/#events-update:options) when options changes we don't need separate watcher for it.That way it will do just one request instead of two.