Skip to content

Remove package json and npm references#201

Merged
tarekio merged 3 commits intomainfrom
remove-package-json-and-npm-refs
Oct 1, 2025
Merged

Remove package json and npm references#201
tarekio merged 3 commits intomainfrom
remove-package-json-and-npm-refs

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Sep 30, 2025

Jira Issue

  1. [Add links to jira issues]

Description

Issue

The project included package.json and package-lock.json files that were originally used as a reference for JavaScript packages manually installed in the static/js folder and for Dependabot vulnerability alerts. However:

  • package.json was frequently out of sync with actual package versions in static/js
  • Manual package management meant the dependency manifest wasn't reliable
  • Recently added GitHub Actions tooling now directly scans JavaScript dependencies in the static/js folder, making package.json redundant

Solution

  • Removed package.json and package-lock.json files
  • Updated CONTRIBUTING.md development setup instructions:
    • Removed npm installation step
    • Updated Prettier usage to use npx prettier for manual formatting

Result

  • Eliminates outdated/misleading dependency manifest
  • JavaScript vulnerability scanning now handled directly by GitHub Actions
  • Developers no longer need Node.js/npm installed locally
  • JavaScript/CSS formatting still available via npx prettier

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@coderabbitai
Copy link

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-package-json-and-npm-refs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tarekio tarekio requested a review from level09 September 30, 2025 23:44
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean & Ready to Merge 👍

@tarekio tarekio merged commit 5fd3f77 into main Oct 1, 2025
9 checks passed
@tarekio tarekio deleted the remove-package-json-and-npm-refs branch October 1, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants