Skip to content

Adjust props syntax and fix typo#195

Merged
tarekio merged 4 commits intomainfrom
adjust-props-syntax-and-clean-up
Sep 28, 2025
Merged

Adjust props syntax and fix typo#195
tarekio merged 4 commits intomainfrom
adjust-props-syntax-and-clean-up

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Sep 19, 2025

Jira Issue

  1. [Add links to jira issues]

Description

Issue

  • Some components use the invalid :="props" binding instead of the correct v-bind="props".
  • The bulletinDrawer reference in incidents and actors pages is a typo — it should be actorDrawer and incidentDrawer.

Solution

  • Replaced all instances of :="props" with the correct v-bind="props".
  • Fixed typos by replacing bulletinDrawer with actorDrawer in the Actors page and with incidentDrawer in the Incidents page.

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron self-assigned this Sep 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 19, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch adjust-props-syntax-and-clean-up

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tarekio tarekio requested a review from level09 September 25, 2025 22:13
level09
level09 approved these changes Sep 28, 2025
View reviewed changes
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go !

@tarekio tarekio merged commit 0fcd73d into main Sep 28, 2025
8 checks passed
@tarekio tarekio deleted the adjust-props-syntax-and-clean-up branch September 28, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@level09 level09 level09 approved these changes

+1 more reviewer

@tarekio tarekio tarekio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@apodacaduron apodacaduron

Labels

project i

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apodacaduron @level09 @tarekio