Skip to content

Improve setting labels in diff (System Administration)#194

Merged
tarekio merged 12 commits intomainfrom
BYNT-1468-Use-setting-name-in-system-settings-diff
Oct 1, 2025
Merged

Improve setting labels in diff (System Administration)#194
tarekio merged 12 commits intomainfrom
BYNT-1468-Use-setting-name-in-system-settings-diff

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Sep 19, 2025 •
edited by atlassian bot
Loading

Jira Issue

  1. BYNT-1468

Description

Issue

  • The diff dialog currently displays raw variable names, which are confusing for end users.
  • The dialog header has a yellow background and extra padding that doesn’t match the rest of the UI.

Solution

  • Removed the yellow background and unnecessary padding from the top of the diff dialog.
  • Updated the diff tool to use custom labels where available.
  • For fields without custom labels, automatically transform keys into human-friendly title case.

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron self-assigned this Sep 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 19, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BYNT-1468-Use-setting-name-in-system-settings-diff

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tarekio tarekio requested a review from level09 September 24, 2025 23:19
level09
level09 approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found inconsistency in labels displayed in the diff, but traced down to backend and fixed them :

Image

PR good to go

@tarekio tarekio merged commit da5d5ed into main Oct 1, 2025
9 checks passed
@tarekio tarekio deleted the BYNT-1468-Use-setting-name-in-system-settings-diff branch October 1, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@level09 level09 level09 approved these changes

+1 more reviewer

@tarekio tarekio tarekio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@apodacaduron apodacaduron

Labels

project i

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apodacaduron @level09 @tarekio