Skip to content

Add scroll to menu in system administration page#193

Merged
tarekio merged 7 commits intomainfrom
BYNT-1467-Add-scroll-to-system-setting-menu
Sep 28, 2025
Merged

Add scroll to menu in system administration page#193
tarekio merged 7 commits intomainfrom
BYNT-1467-Add-scroll-to-system-setting-menu

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Sep 18, 2025

Jira Issue

  1. BYNT-1467

Description

Issue

On the System Administration page, the menu becomes partially inaccessible on low-resolution screens. During usability testing, some users didn’t notice the notification at all. Additionally, other panels can overflow on smaller screens, making some content hard or impossible to access.

Solution

  • Enabled scrolling on the System Administration menu.
  • Added buttons inside the menu to scroll directly to the top or bottom.
  • Added scrollbars to other panels on smaller screens to ensure all content is accessible.

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BYNT-1467-Add-scroll-to-system-setting-menu

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert to normal scroll. Also, the menu seems to be squeezed, let's restore previous look, and use primary color for selection.

@apodacaduron
Copy link
Contributor Author

Reverted to regular scroll, and changed to primary color

Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for now, we can improve more in the future.

@tarekio tarekio requested a review from level09 September 26, 2025 23:40
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good simple fix for the issue. but I think the UX is still not ideal, not because of CSS but because of MAC defaults (hides scrollbars) so there is no way for the user to tell if he can scroll of not.

Maybe we can implement a simple UI enhancement here ? like show a little tiny UI detail when there is a scrollbar?

Screen.Preview.2025-09-27.at.15.58.38.mp4

@tarekio tarekio merged commit 4d417d5 into main Sep 28, 2025
8 checks passed
@tarekio tarekio deleted the BYNT-1467-Add-scroll-to-system-setting-menu branch September 28, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants