Skip to content

fix: adjust search request data structure for specific endpoint#191

Merged
tarekio merged 2 commits intomainfrom
fix-incident-rel-search-again
Sep 14, 2025
Merged

fix: adjust search request data structure for specific endpoint#191
tarekio merged 2 commits intomainfrom
fix-incident-rel-search-again

Conversation

@tarekio
Copy link
Contributor

@tarekio tarekio commented Sep 13, 2025

Jira Issue

  1. https://syriajustice.atlassian.net/browse/BYNT-1461

Description

Amend q in requestData per search endpoint. This is to accomodate the incident endpoint which accepts one query (vs A/B which accept multiple queries with bool ops).

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@coderabbitai
Copy link

coderabbitai bot commented Sep 13, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-incident-rel-search-again

Comment @coderabbitai help to get the list of available commands and usage tips.

level09
level09 approved these changes Sep 13, 2025
View reviewed changes
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this fixes the immediate issue cleanly. in the future we could improve this by adding a queryFormat property to each components instead of hardcoded string matching with endpoints, I think it would be less fragile and offer better separation.

@tarekio
Copy link
Contributor Author

tarekio commented Sep 13, 2025

Looks good, this fixes the immediate issue cleanly. in the future we could improve this by adding a queryFormat property to each components instead of hardcoded string matching with endpoints, I think it would be less fragile and offer better separation.

Done 🫡

@tarekio tarekio merged commit b5f802f into main Sep 14, 2025
8 checks passed
@tarekio tarekio deleted the fix-incident-rel-search-again branch September 14, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@level09 level09 level09 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarekio @level09