Event locations list drop down after selection#183
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…se load the normal table
…irst, else load the normal table" This reverts commit e244a30.
…460-Event-locations-list-drop-down-after-selection
level09
left a comment
There was a problem hiding this comment.
Great PR! I like the simplification and the use of Autocomplete features.
My only comment: triggering search on focus creates a slightly annoying UX. It might be better to start searching once the user types. Some apps wait for 2–3 characters, but I’m fine with starting right after the first character.
CleanShot.2025-09-17.at.10.33.23.mp4
|
Summary: Refactored Previously, the component fetched items from the API as the user typed. When the user pressed enter, it compared the searched value against the list of items to ensure only existing values were inserted. This required a lot of internal validations, increasing the risk of bugs. By switching to |
Jira Issue
Description
When searching for an event location, the dropdown list of results appears as expected. However, after selecting a location, the dropdown reappears and remains open, covering the date fields. This prevents users from immediately interacting with the date fields.
Notes: This PR refactors the
SearchFieldcomponent. We replacedv-comboboxwithv-autocomplete, which automatically enforces selection from the existing items list. This eliminates the need for much of the previous manual validation and selection logic, simplifying the component and improving usability.Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]