Skip to content

Event locations list drop down after selection#183

Merged
tarekio merged 10 commits intomainfrom
BYNT-1460-Event-locations-list-drop-down-after-selection
Sep 26, 2025
Merged

Event locations list drop down after selection#183
tarekio merged 10 commits intomainfrom
BYNT-1460-Event-locations-list-drop-down-after-selection

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Sep 8, 2025

Jira Issue

  1. BYNT-1460

Description

When searching for an event location, the dropdown list of results appears as expected. However, after selecting a location, the dropdown reappears and remains open, covering the date fields. This prevents users from immediately interacting with the date fields.

Notes: This PR refactors the SearchField component. We replaced v-combobox with v-autocomplete, which automatically enforces selection from the existing items list. This eliminates the need for much of the previous manual validation and selection logic, simplifying the component and improving usability.

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio September 8, 2025 20:31
@apodacaduron apodacaduron self-assigned this Sep 8, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BYNT-1460-Event-locations-list-drop-down-after-selection

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! I like the simplification and the use of Autocomplete features.

My only comment: triggering search on focus creates a slightly annoying UX. It might be better to start searching once the user types. Some apps wait for 2–3 characters, but I’m fine with starting right after the first character.

CleanShot.2025-09-17.at.10.33.23.mp4

@apodacaduron
Copy link
Contributor Author

Summary: Refactored SearchField.js component. Visually, it should appear almost the same as the original version. The main change is replacing v-combobox with v-autocomplete.

Previously, the component fetched items from the API as the user typed. When the user pressed enter, it compared the searched value against the list of items to ensure only existing values were inserted. This required a lot of internal validations, increasing the risk of bugs.

By switching to v-autocomplete, we delegate these validations to Vuetify, since the component only allows selecting existing values. This significantly simplifies the component and also addresses the issue of the dropdown not closing.

@tarekio tarekio merged commit 843f61a into main Sep 26, 2025
8 checks passed
@tarekio tarekio deleted the BYNT-1460-Event-locations-list-drop-down-after-selection branch September 26, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants