Skip to content

Warning when closing Activity search dialog#182

Merged
tarekio merged 2 commits intomainfrom
BYNT-1459-Warning-when-closing-Activity-search-dialog
Sep 15, 2025
Merged

Warning when closing Activity search dialog#182
tarekio merged 2 commits intomainfrom
BYNT-1459-Warning-when-closing-Activity-search-dialog

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Sep 8, 2025

Jira Issue

  1. BYNT-1459

Description

Warning when closing Activity search dialog:

Component emitted event "close" but it is not declared

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio September 8, 2025 18:55
@apodacaduron apodacaduron self-assigned this Sep 8, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch BYNT-1459-Warning-when-closing-Activity-search-dialog

Comment @coderabbitai help to get the list of available commands and usage tips.

@apodacaduron apodacaduron changed the title add close event to emits, remove colors and space buttons Warning when closing Activity search dialog Sep 8, 2025
@tarekio tarekio requested a review from level09 September 11, 2025 20:07
@tarekio tarekio merged commit 3b146a6 into main Sep 15, 2025
8 checks passed
@tarekio tarekio deleted the BYNT-1459-Warning-when-closing-Activity-search-dialog branch September 15, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants