enferno/utils/graph_utils.py (1)

62-64: Location titles now always visible — confirm authorization intent; simplify type checks

Exposing Location titles regardless of access might be intentional; please confirm it matches the data access policy. Also, prefer class checks over tablename strings.

-        if instance and model.__tablename__ in ["actor", "incident", "bulletin"]:
+        if instance and model in (Actor, Incident, Bulletin):
             if self.user and self.user.can_access(instance):
                 title = instance.title
-        elif instance and model.__tablename__ == "location":
+        elif instance and model is Location:
             title = instance.title

enferno/utils/search_utils.py (1)

119-124: Incident path now consumes a dict — keep deterministic ordering

This simplifies inputs, but you dropped the explicit ordering used inside incident_query’s stmt. Add a default order to keep stable pagination/UX.

-            result = select(Incident)
+            result = select(Incident).order_by(Incident.id.desc())
             if conditions:
                 result = result.where(and_(*conditions))
             return result

Alternatively, just return the stmt from incident_query to reuse its CTE + ordering:

-            _, conditions = self.incident_query(self.search)
-            result = select(Incident).order_by(Incident.id.desc())
-            if conditions:
-                result = result.where(and_(*conditions))
-            return result
+            stmt, _ = self.incident_query(self.search)
+            return stmt

enferno/tasks/__init__.py (1)

1432-1435: Avoid materializing all rows; iterate lazily and harden ID extraction.

.all() forces full materialization and can blow up memory for big graphs. Iterate the ScalarResult directly. Also, the docstring mentions user_id (not in signature) — update it.

Apply:

-    for item in result_set.scalars().unique().all():
+    for item in result_set.scalars().unique():
         current_graph = graph_utils.get_graph_json(entity_type, item.id)
         graph = current_graph if graph is None else graph_utils.merge_graphs(graph, current_graph)

Follow-up (optional): Add a practical upper bound (e.g., 500 items) or truncate with a warning to prevent generating unusably dense graphs.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge Base: Disabled due to data retention organization setting

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.