Skip to content

Broken progress steps in sheets import#160

Merged
tarekio merged 20 commits intomainfrom
BYNT-1428-Broken-progress-steps-in-Sheets-Import
Aug 26, 2025
Merged

Broken progress steps in sheets import#160
tarekio merged 20 commits intomainfrom
BYNT-1428-Broken-progress-steps-in-Sheets-Import

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Aug 15, 2025

Jira Issue

  1. BYNT-1428

Description

Overall the steps are broken.
If you’re in page 2 and return to page 1, you’re stuck there. The file remains, but if you remove and upload another one, sheets list are not updated and you can’t go forward.
I think best solution now is to add a button to proceed to page 2 for now.
In page 3, there’s no way to go back to page 2. Also, process button appears at the bottom vs on top in previous page. > Let’s make this whole process consistent.
Let’s also change to numbers and mark tasks as completed: Stepper component — Vuetify

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio August 15, 2025 16:55
@apodacaduron apodacaduron self-assigned this Aug 15, 2025
Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current progress is good. It created/exposed some other issues though. Here's a list:

  1. 'Next' button in first page is disabled with csv (there's no sheet, this is after going back to this page)
  2. Buttons should be at top to remain consistent with the rest of the ui.
  3. There are lots of inconsistencies in the second page. First, let move the map selector next to the map name. Next, we should arrange the buttons to Delete, Update, Create New. Last, let's squeeze the 'Actor Fields` toolbar, make the 'Shields Fields' match visually, push down the search.
Image
  1. The steps appear to be clickable but they're not. Let's disable this as it gives user impression they can move between steps
Image
  1. Let's rename the steps to Upload or Select, Map, Upload More, Status.
  2. Let's use button design from our design system.
Image

@tarekio tarekio merged commit d2590e4 into main Aug 26, 2025
7 checks passed
@tarekio tarekio deleted the BYNT-1428-Broken-progress-steps-in-Sheets-Import branch August 26, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants