Merged
Conversation
…428-Broken-progress-steps-in-Sheets-Import
tarekio
suggested changes
Aug 18, 2025
Contributor
There was a problem hiding this comment.
Current progress is good. It created/exposed some other issues though. Here's a list:
- 'Next' button in first page is disabled with csv (there's no sheet, this is after going back to this page)
- Buttons should be at top to remain consistent with the rest of the ui.
- There are lots of inconsistencies in the second page. First, let move the map selector next to the map name. Next, we should arrange the buttons to Delete, Update, Create New. Last, let's squeeze the 'Actor Fields` toolbar, make the 'Shields Fields' match visually, push down the search.
- The steps appear to be clickable but they're not. Let's disable this as it gives user impression they can move between steps
- Let's rename the steps to Upload or Select, Map, Upload More, Status.
- Let's use button design from our design system.
…428-Broken-progress-steps-in-Sheets-Import
…428-Broken-progress-steps-in-Sheets-Import
…tps://github.com/sjacorg/bayanat into BYNT-1428-Broken-progress-steps-in-Sheets-Import
level09
approved these changes
Aug 26, 2025
tarekio
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]