Skip to content

Dialogs are fullscreen and not sizing properly#157

Merged
tarekio merged 17 commits intomainfrom
BYNT-1430-Searching-for-related-actors-is-covering-the-hole-screen
Aug 25, 2025
Merged

Dialogs are fullscreen and not sizing properly#157
tarekio merged 17 commits intomainfrom
BYNT-1430-Searching-for-related-actors-is-covering-the-hole-screen

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Aug 13, 2025

Jira Issue

  1. (BYNT-1430)[https://syriajustice.atlassian.net/browse/BYNT-1430]
  2. (BYNT-1432)[https://syriajustice.atlassian.net/browse/BYNT-1432]

Description

Due to recent changes in #97 an update was made to the latest vuetify version that included some changes, that caused the dialog to ignore custom sizes when the prop fullscreen was used. This update changes the width through the content styles

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio August 13, 2025 22:10
@apodacaduron apodacaduron self-assigned this Aug 13, 2025
Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Nit picking: event and geo dialogs are still full screen, we can minimize them to fit the fields.

@apodacaduron
Copy link
Contributor Author

@tarekio do you mean the dialogs that are in the split view?

Bulletin dialog event Actor dialog event
Screenshot_20250815_131134 Screenshot_20250815_131154

@tarekio
Copy link
Contributor

tarekio commented Aug 18, 2025

@tarekio do you mean the dialogs that are in the split view?

Bulletin dialog event Actor dialog event
Screenshot_20250815_131134 Screenshot_20250815_131154

Correct, it should look like the one in the Actor.

@tarekio tarekio requested a review from level09 August 18, 2025 23:10
Copy link
Collaborator

@level09 level09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. it would be just better if we can reuse vuetify classes like w-66 instead of using .style attribtues

@apodacaduron
Copy link
Contributor Author

@tarekio updated events and geolocation should use the regular dialog dimensions now

@apodacaduron
Copy link
Contributor Author

@level09 I set 60% as the initial default, but the split-view component actually emits the panel width as a percentage. We then apply that value to both the left and right panel widths, ensuring child dialogs resize correctly. For example: @right-width-changed="rightDialogProps['content-props'].style.width = $event"

@tarekio
Copy link
Contributor

tarekio commented Aug 22, 2025

@tarekio updated events and geolocation should use the regular dialog dimensions now

This is better but these dialogs now appear in the middle of the screen, covering left side. They should appear on right only, centered.

@apodacaduron
Copy link
Contributor Author

@tarekio the event and geolocation dialogs should now be contained into the right panel

@apodacaduron apodacaduron requested a review from tarekio August 22, 2025 16:11
Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now. Bulletin is different than Actor and Incident, but we'll redesign these dialogs soon so we can fix that at that point.

@tarekio tarekio merged commit a3b9091 into main Aug 25, 2025
6 of 7 checks passed
@tarekio tarekio deleted the BYNT-1430-Searching-for-related-actors-is-covering-the-hole-screen branch August 25, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants