Conversation
…etin-card/incident-card
…r better readability
…tems-add-show-more-button
tarekio
suggested changes
Aug 8, 2025
Contributor
tarekio
left a comment
There was a problem hiding this comment.
- Let's triple the length of initial length, and 2. let's stick to current design elements (use load more component in relations).
level09
requested changes
Aug 8, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
I found another bug but not related to this MR
we are resetting the wrong variable in RelatedIncidentsCard and RelatedActorsCard
this.bulletinPage = 1
So maybe we could also fix it along the way.
…98-Cap-description-length-in-related-items-add-show-more-button
…ow-more-button' of https://github.com/sjacorg/bayanat into BYNT-598-Cap-description-length-in-related-items-add-show-more-button
Contributor
Author
|
@tarekio length has been tripled from 5 to 15 lines and updated the style of the Show more button to be similar to the Load more button in relations |
Contributor
|
Let's remove this from data tables please. We should simply truncate titles in the tables so each item appears on one line only. |
…98-Cap-description-length-in-related-items-add-show-more-button
Contributor
Author
|
@tarekio removed component from data tables and added a simple class to truncate to 1 line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
This PR introduces a new reusable ReadMore component that truncates long descriptions and adds a "Show More / Show Less" toggle for better readability.
While the original issue was specific to related items cards, the component has been applied more broadly across the project where long text is displayed. This improves the overall consistency and UX in multiple areas.
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]