Merged
Conversation
tarekio
approved these changes
Jul 22, 2025
Collaborator
|
@tarekio This will result in a strange outcome. users can add empty events with no data. Is that okay or desired ? |
level09
approved these changes
Jul 31, 2025
Collaborator
level09
left a comment
There was a problem hiding this comment.
This is technically correct.
But it will produce bad UX , blank events would be confusing.
Contributor
Agree, but title is not required. Let's address this in another PR, we'll add better validation for event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue
Description
Events can’t be saved without providing a title, we don’t need always to add a title for the event.
Checklist
API Changes (if applicable)
Additional Notes
[Any other relevant information]