Skip to content

Show delete button as soon as ID Number input is dirty#142

Merged
tarekio merged 3 commits intomainfrom
BYNT-1405-ID-field-can-t-be-reset-directly
Aug 1, 2025
Merged

Show delete button as soon as ID Number input is dirty#142
tarekio merged 3 commits intomainfrom
BYNT-1405-ID-field-can-t-be-reset-directly

Conversation

@apodacaduron
Copy link
Contributor

@apodacaduron apodacaduron commented Jul 21, 2025

Jira Issue

  1. BYNT-1405

Description

If you select a type for the ID field then you have to fill the related field otherwise you will not be able to save the actor.

Work around you can add another ID field and delete the first one then save.

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • New strings prepared for translations

API Changes (if applicable)

  • Permissions checked
  • Endpoint tests added

Additional Notes

[Any other relevant information]

@apodacaduron apodacaduron requested a review from tarekio July 21, 2025 18:43
@apodacaduron apodacaduron self-assigned this Jul 21, 2025
@apodacaduron apodacaduron changed the title Show delete button as soon input is dirty Show delete button as soon as ID Number input is dirty Jul 21, 2025
Copy link
Contributor

@tarekio tarekio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal but fine for now. I think we better add only after the user clicks on '+' button. This is to be consistent with the rest of the UI (e.g. events, media, etc. We can address this in a future PR.

@tarekio tarekio requested a review from level09 July 22, 2025 18:42
@tarekio tarekio merged commit 0b2d4cf into main Aug 1, 2025
6 of 7 checks passed
@tarekio tarekio deleted the BYNT-1405-ID-field-can-t-be-reset-directly branch August 1, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants